Convert to v2, addon. Just wrap fetch.
#754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
reviewed
Nov 6, 2024
| function isPlainObject(obj) { | ||
| return Object.prototype.toString.call(obj) === '[object Object]'; | ||
| } | ||
|
|
||
| /** | ||
| * Helper function that turns the data/body of a request into a query param string. | ||
| * This is directly copied from jQuery.param. |
There was a problem hiding this comment.
There's also https://github.com/knowledgecode/jquery-param, so wondering if we should still include this in ember-fetch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is (what I think is) the goal.
We can decide if we want to move towards this goal incrementally or deciding that this is what we want and skip all the in-between.
To move incrementally, we'd need to resolve the following PRs:
Ember < 3.28, upgrades toEmber 4.12, supportsEmber 5#741Which... we can do -- I'm not sure it's worth keeping CI green through all that though.
ember-fetchis in a bit of disrepair.Support:
@ember/test-waitersv3+I'm not sure what the fastboot support story would be, but Node natively has
fetch,AbortController, etc.Dropped Support:
AbortControllerexists onglobalThisHeadersexists onglobalThisResponseexists onglobalThisSince
ember-auto-importtests against 3.4.0, and ember-auto-import is the only real requirement for this change, there is no change in supported ember-source.If anything, the constraining function is
@ember/test-waitersChanges:
After this PR: