feat: new style for "package" headers #856
Conversation
| if (typeName != 'namespace') { | ||
| console.warn( | ||
| e1, | ||
| 'fetching by class or module failed, retrying as namespace' | ||
| ); | ||
| return this.store.find('namespace', param).catch((e2) => { | ||
| return this.store.findRecord('namespace', param).catch((e2) => { |
There was a problem hiding this comment.
this change should be separated out and landed irregardless, this code is deprecated and will break in 5.0 @jaredgalanis @jenweber
|
We reviewed this at the Learning Team meeting today and like the improvements to visual hierarchy on the package pages. We spotted 2 changes needed, then this can be merged:
I also noticed that the mobile look could use some iteration, but that's not a blocker. It would be a good issue for a new contributor. Let us know if you want any help making these adjustments! Lastly, out of scope for this PR, but maybe helpful: when writing new docs, if ember data contributors use more specific h1s like "Overview of Something" vs "Overview", the topic will show up more easily in search engine results. |
|
P.S. Thank you for your work on this! |
|
Found this PR during the core-learning meeting, since we are currently working on the #710 we'll make sure this comes along in some shape or form :) |
mansona
force-pushed
the
new-nav-style
branch
from
e028b41 to
a1a2e3a
Compare
✅ Deploy Preview for ember-api-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Will close this PR in favour of the new design, took a screenshot and will add that to the projectboard |
No description provided.