Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to include fully local run #896

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Conversation

jaredgalanis
Copy link
Member

@jaredgalanis jaredgalanis commented Nov 10, 2023

  • the instructions to run ember-api-docs and ember-api-docs-data fully locally were housed in ember-jsonapi-docs, but having them here in the actual frontend seems a bit more intuitive
  • this related PR makes ember-jsonapi-docs point here to this readme for running ember-api-docs fully locally Cleanup README ember-jsonapi-docs#135
  • as does this PR for ember-api-docs-data Clean up readme ember-api-docs-data#22

- the instructions to run ember-api-docs and ember-api-docs-data fully locally were housed in ember-jsonapi-docs, but having them here in the actual frontend seems a bit more intuitive
Copy link

netlify bot commented Nov 10, 2023

Deploy Preview for ember-api-docs ready!

Name Link
🔨 Latest commit c55a956
🔍 Latest deploy log https://app.netlify.com/sites/ember-api-docs/deploys/6550159655e4ef0008b7ff46
😎 Deploy Preview https://deploy-preview-896--ember-api-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jaredgalanis jaredgalanis requested a review from mansona November 10, 2023 22:29
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jaredgalanis and others added 2 commits November 11, 2023 19:00
Co-authored-by: Chris Manson <[email protected]>
Co-authored-by: Chris Manson <[email protected]>
@jaredgalanis jaredgalanis requested a review from mansona November 12, 2023 00:00
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@jaredgalanis jaredgalanis merged commit 5de2fb7 into master Nov 14, 2023
4 checks passed
@jaredgalanis jaredgalanis deleted the jaredgalanis-patch-1 branch November 14, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants