Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require ember >= 4.4, node >= 16 #1478

Merged
merged 10 commits into from
Sep 5, 2023
Merged

Require ember >= 4.4, node >= 16 #1478

merged 10 commits into from
Sep 5, 2023

Conversation

RobbieTheWagner
Copy link
Member

No description provided.

@RobbieTheWagner RobbieTheWagner changed the title Update to Ember 5 Update to Ember 5, drop node 14 support Aug 22, 2023
@SergeAstapov SergeAstapov mentioned this pull request Aug 22, 2023
Closed
@RobbieTheWagner RobbieTheWagner changed the title Update to Ember 5, drop node 14 support Require ember >= 4.4, node >= 16 Aug 22, 2023
@RobbieTheWagner RobbieTheWagner mentioned this pull request Aug 22, 2023
Merged
@RobbieTheWagner
Copy link
Member Author

@SergeAstapov @patricklx any ideas why the tests are failing here? I was trying to get these updates in before cutting a release.

@patricklx
Copy link
Contributor

maybe you need to delete the action npm cache?
also, locally I needed to add "@ember/string": "*" to the test-apps/new-addon/package.json dependencies, not devDependencies

@patricklx
Copy link
Contributor

Also:
https://discord.com/channels/480462759797063690/480523424121356298/1141065006650245140

@patricklx
Copy link
Contributor

Need to remove ie11

@RobbieTheWagner
Copy link
Member Author

Thanks @patricklx! Really appreciate the help 😄

@RobbieTheWagner RobbieTheWagner merged commit d86e566 into master Sep 5, 2023
@RobbieTheWagner RobbieTheWagner deleted the ember-5 branch September 5, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobbieTheWagner @patricklx