Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file titles to code blocks #37

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

akashdsouza
Copy link

#34

Should the class name also be changed from lang-app/component/person.js to lang-javascript?

Copy link
Member

@sivakumar-kailasam sivakumar-kailasam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akashdsouza can you please make the pr pass?

@akashdsouza
Copy link
Author

I'm sorry. I have been a bit busy. I will try to make the PR pass by tonight

@akashdsouza akashdsouza force-pushed the patch_add_titles_code branch from f0e6ab1 to 1a20c35 Compare September 6, 2017 11:27
@akashdsouza
Copy link
Author

Done

@locks locks merged commit 5846014 into ember-learn:master Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants