-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non supported bugfix and security patch until dates #1083
Add non supported bugfix and security patch until dates #1083
Conversation
Right now, the no longer maintained table suggests that the last release for the 3.28 LTS was 3.28.11. This is incorrect, as 3.28.12 was released in May of 2023. Let's update this table to reflect that.
✅ Deploy Preview for ember-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
7e5693c
to
ced27d6
Compare
Right now, the no longer maintained table suggests that the last release for the 3.24 LTS was 3.24.6. This is incorrect, as 3.24.7 was released in November of 2022. Let's update this table to reflect that.
Right now, the no longer maintained table suggests that the last release for the 3.20 LTS was 3.20.3. This is incorrect, as 3.20.6 was released in November of 2020. Let's update this table to reflect that.
It would be useful to show rough "Bugfix until" and "Security patches until" dates for the no longer maintained LTS versions (similar to how we do for the currently maintained LTS versions). Let's make it so!
ced27d6
to
8281551
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the column from the last minor date to the LTS promotion date based on the blog post dates
Thank you for this; if you're up for another PR after this, I think removing that latest minor version column could be useful. It seems like something that is irksome to keep up to date. We could link to the npm versions page instead https://www.npmjs.com/package/ember-source?activeTab=versions |
Sure thing! Good idea to switch the last minor date to the promotion date. I think that it was a little funky because some LTS versions received patches after the cutoffs if I remember correctly. I'll make a separate PR to drop that column and add some text to link to the versions page on NPM instead. |
@ember-learn/learning-core-team who can review Percy? |
Per this message in the ember-js discord, let's add a couple of new columns (Bugfixes until and Security patches until) to the no longer maintained LTS table on the
releases/lts
route.While glossing over this, I think that I caught a few instances where we were showing the incorrect minor version / date for a few LTS versions as well, but definitely worth double checking them.