Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add not-found route #787

Merged
merged 1 commit into from
Mar 7, 2021
Merged

Add not-found route #787

merged 1 commit into from
Mar 7, 2021

Conversation

bertdeblock
Copy link
Contributor

@bertdeblock bertdeblock commented Mar 5, 2021 •
edited
Loading

Far from perfect, but at the moment non-existent URLs return a blank screen.

Let me know if I should update anything related to UI, UX, A11Y, copy and so on.

Screenshot 2021-03-05 at 19 39 39 (2)

@bertdeblock bertdeblock force-pushed the add-not-found-route branch from b334775 to f4d2600 Compare March 5, 2021 18:56
ijlee2
ijlee2 reviewed Mar 6, 2021
View reviewed changes
app/templates/not-found.hbs Outdated Show resolved Hide resolved
ijlee2
ijlee2 reviewed Mar 6, 2021
View reviewed changes
app/routes/not-found.js Outdated Show resolved Hide resolved
ijlee2
ijlee2 reviewed Mar 6, 2021
View reviewed changes
app/router.js Show resolved Hide resolved
ijlee2
ijlee2 reviewed Mar 6, 2021
View reviewed changes
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the lack of a not-found page in the Ember.js website. I think the solution that you took is good, and left a few suggestions for improvement. Will you have a look?

@bertdeblock bertdeblock force-pushed the add-not-found-route branch 3 times, most recently from 94c0aeb to bf148c8 Compare March 6, 2021 09:09
@bertdeblock
Copy link
Contributor Author

Looking into the failing checks. Could they be related to the lock file changes? I also had some lock files changes when installing all modules for the first time.

@bertdeblock
Copy link
Contributor Author

This seems to be the issue we're running into:
embroider-build/ember-auto-import#340

This PR seems to fix it:
embermap/ember-cli-fastboot-testing#434

@ijlee2
Copy link
Member

ijlee2 commented Mar 6, 2021

@bertdeblock Ah, I think I see what you meant by failing checks (Netlify deploy logs are showing errors). Yeah, if installing ember-cli-fastboot-testing caused the issue, let's skip on adding the status code test and uninstall the addon for now.

Once the embermap/ember-cli-fastboot-testing#434 is merged, we can try installing the addon and adding the test back.

@bertdeblock bertdeblock force-pushed the add-not-found-route branch from 2150cb7 to 94535e2 Compare March 6, 2021 16:43
@bertdeblock
Copy link
Contributor Author

bertdeblock commented Mar 6, 2021 •
edited
Loading

@ijlee2 Removed the Fastboot test for now. Will create a separate PR for the test.

ijlee2
ijlee2 approved these changes Mar 7, 2021
View reviewed changes
Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for working on this!

@ijlee2 ijlee2 merged commit d3c289f into ember-learn:master Mar 7, 2021
@bertdeblock bertdeblock deleted the add-not-found-route branch September 1, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijlee2 ijlee2 ijlee2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bertdeblock @ijlee2