add couple of remarks regarding inline/block usage of -if-

[ciur]

Add couple of remarks regarding usage of block and inline version of if.

[locks]

Thank you for taking the time to contribute!

I noticed a couple of things with your suggestions.
Generally, we try to focus content on the happy path (the working code examples) because people tend to miss the "won't work" wording and copy paste the code and get confused.
Another thing I noticed is that in the first example you could (and should) do <button disabled={{@disabled}} class="btn">Sign In</button> which is much more direct and does not require the repetition.

What do you think of improving the API documentation for {{if}} and putting a note in the Guides to check https://api.emberjs.com/ember/4.1/classes/Ember.Templates.helpers/methods/if?anchor=if for the full documentation?

[ciur]

What do you think of improving the API documentation for {{if}} and putting a note in the Guides to check https://api.emberjs.com/ember/4.1/classes/Ember.Templates.helpers/methods/if?anchor=if for the full documentation?

@locks do I understand correctly that you want me move added remarks to API documentation? or maybe you want me to delete remarks entirely and just to point user to the already exiting API docs?
I don't understand your suggestion, please rephrase.

[jenweber]

@locks can you take another look at this, and ciur's comments above? Thanks!

[jenweber]

Hi @ciur thanks for bringing this up! The learning team re-reviewed this PR and we have some suggested changes for you to consider.

One thing that jumped out to me is that with your code example additions, we now give some more real-life examples. We've heard before that people had trouble finding a full example of if-else if - else, so this will be a nice improvement!

[bertdeblock]

The most common way to conditionally render an attribute would be like this:

<button disabled={{@disabled}} class="btn">Sign In</button>

Personally, I would use a different example.

[bertdeblock]

Inline if can be used only inside attribute values of HTML elements.

That's not true.
Literally the example above shows valid usage that's unrelated to HTML attributes.
These are valid examples as well:

Conditional argument value:

<Foo @foo={{if this.bar "bar" "baz"}} />

Applying a modifier conditionally:

<button type="button" {{(if @onClick (modifier this.on "click" @onClick))}} />