Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing template-tag feature flag #2080

Merged
merged 7 commits into from
Jan 21, 2025
Merged

Introducing template-tag feature flag #2080

merged 7 commits into from
Jan 21, 2025

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Dec 3, 2024

This is a working implementation of feature flagging, and an initial bit of content using the template-tag feature flag.

The only affordance to activate a default-disabled flag is to edit it into a query param.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for ember-guides ready!

Name Link
🔨 Latest commit c2ac348
🔍 Latest deploy log https://app.netlify.com/sites/ember-guides/deploys/678feb27e2853a0008993c33
😎 Deploy Preview https://deploy-preview-2080--ember-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kategengler
Copy link
Contributor

PR to fix Trailing History empress/guidemaker#117

@ef4 ef4 force-pushed the feature-flag branch 2 times, most recently from a373fff to c80c9f8 Compare December 10, 2024 19:05
@ef4
Copy link
Contributor Author

ef4 commented Dec 10, 2024

PR is updated to assume the guidemaker fix has landed (which it has not right now). It should be green if that published as a compatible release.

@ef4
Copy link
Contributor Author

ef4 commented Dec 18, 2024

There is a sporadic CI failure. I've confirmed that when it happens its a fetch failure:

TypeError: Failed to fetch
    at ApplicationAdapter._fetchRequest (http://localhost:7357/assets/vendor.js:22662:16)
    at ApplicationAdapter._callee$ (http://localhost:7357/assets/vendor.js:22605:29)
    at tryCatch (http://localhost:7357/assets/vendor.js:21627:1064)
    at Generator.<anonymous> (http://localhost:7357/assets/vendor.js:21627:3010)
    at Generator.next (http://localhost:7357/assets/vendor.js:21627:1701)
    at asyncGeneratorStep (http://localhost:7357/assets/vendor.js:21628:72)
    at _next (http://localhost:7357/assets/vendor.js:21629:165)
    at http://localhost:7357/assets/vendor.js:21629:301
    at new Promise (<anonymous>)
    at ApplicationAdapter.<anonymous> (http://localhost:7357/assets/vendor.js:21629:92)"}

@kategengler
Copy link
Contributor

https://github.com/ember-learn/guides-source/actions/runs/12379836293/job/34554877026 on a merge of a content change failed the same way -- lending suspicion of the ember + ember-data upgrade (that moved to real fetch).

@ef4 ef4 marked this pull request as ready for review January 10, 2025 20:02
@ef4 ef4 merged commit b974634 into master Jan 21, 2025
4 checks passed
@ef4 ef4 deleted the feature-flag branch January 21, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants