Remove pauseTest workaround #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows-up emberjs#497 which introduced this because QUnit 2.8 didn't support changing an existing `assert.timeout()` by calling it again in the same test (it would leave the old one unchanged, and start a second timeout). This was fixed in QUnit 2.9.3, released in Oct 2019. The ember-qunit package declares a peer dependency on `[email protected]`, which should remove the need for this workaround. Ref emberjs#496.
|
The main reason I care is to confirm that it all works for what ember-qunit ultimately needs. (The isolated issue that we identified back then is long covered by upstream tests, but I'd like to confirm that there isn't something else at play.) |
NullVoxPopuli
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows-up #497 which introduced this because QUnit 2.8 didn't support changing an existing
assert.timeout()by calling it again in the same test (it would leave the old one unchanged, and start a second timeout).This was fixed in QUnit 2.9.3, released in Oct 2019.
The ember-qunit package declares a peer dependency on
[email protected], which should remove the need for this workaround.Ref #496.