Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance RFC #0785 "Introduce new test helpers for rendering (and re-rendering) that obviate the need for get and set" to Stage Recommended #991

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

emberjs-rfcs-bot
Copy link
Collaborator

@emberjs-rfcs-bot emberjs-rfcs-bot commented Nov 29, 2023

Advance #785 to the Recommended Stage

Rendered

Summary

This pull request is advancing the RFC to the Recommended Stage.

An FCP is required before merging this PR to advance.

Recommended Stage Summary

The "Recommended" stage is the final milestone for an RFC. It provides a signal to the wider community to indicate that a feature has been put through its ecosystem paces and is ready to use.

To reach the "Recommended" stage, the following should be true:

If appropriate, the feature is integrated into the tutorial and the guides prose. API documentation is polished and updates are carried through to other areas of API docs that may not directly pertain to the feature.

If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features.

If the proposal updates or replaces an existing feature, high-quality codemods are available.

If needed, Ember debugging tools as well as popular IDE support have been updated to support the feature.

If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended".

Any criteria for "Recommended" for this proposal that were established in the Ready For Release stage have been met.

An FCP is required to enter this stage. Multiple RFCs may be moved as a batch into "Recommended" with the same PR.

Checklist to move to Recommended

  • Criteria specific to this feature: Any additional criteria for "Recommended" for this proposal that were established in the Ready For Release stage have been met.
  • Tutorial: If appropriate, the feature is integrated into the tutorial.
  • Guides: If appropriate, the feature is integrated into the guides prose.
  • API Docs: API documentation is polished and updates are carried through to other areas of API docs that may not directly pertain to the feature.
  • Addon Ecosystem: If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features.
  • Codemods: If the proposal updates or replaces an existing feature, high-quality codemods are available.
  • Debugging Tools: If needed, Ember debugging tools (e.g. Ember Inspector, Deprecation Workflow) have been updated to support the feature.
  • IDE Support: If needed, popular IDE support has been updated to support the feature.
  • Engines, SSR: If needed, ecosystem feature such as Ember Engines, SSR support have been updated to support the feature.
  • Blueprints: Blueprints have been updated to support the feature and to reflect the new best practices implied by this feature.
  • Linting: Lint rules have been updated or added or removed to support the feature and to reflect the new best practices implied by this feature.
  • Deprecations: If this feature implies that other features are no longer best practice, RFCs have been created to deprecate those features.
  • Blog Post: Consider if a blog post should be written to introduce this feature to the community.
  • Feature Suite: If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended".
  • FCP to Recommended: This PR has been converted from a draft to a regular PR and the Final Comment Period label has been added to start the FCP.

Criteria for moving to Recommended (required)

A set of criteria for moving this RFC to the Recommended Stage, following release:

  • Update the testing components section of the official guides to use this pattern.
  • Ensure that guides content for tests is using tracked-built-ins over putting reactive estate on this.

@emberjs-rfcs-bot emberjs-rfcs-bot added RFC Advancement S-Recommended PR to move to the Recommended Stage labels Nov 29, 2023
@ef4
Copy link
Contributor

ef4 commented Dec 1, 2023

This was an RFC that was accepted before our staging process, @kategengler noticed it had unfinished polish work and triggered this PR. Next action here is planning out the remaining documentation. The feature itself does work.

@achambers
Copy link
Contributor

Have added the documentation requirement as per the RFC. However, it seems like this is dependent on the guides recommending GJS/GTS format first.

@ef4
Copy link
Contributor

ef4 commented Oct 25, 2024

Notes on how we'll document this: we should plan to show testing reactivity against tracked built-ins, in favor of using the test context this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Advancement S-Recommended PR to move to the Recommended Stage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants