Add shouldIncludeStyleguide option #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrowlingson
commented
Apr 19, 2018
| includer.options['ember-cli-tailwind'] && | ||
| includer.options['ember-cli-tailwind']['buildTarget']; | ||
| includer.options[this.name] && | ||
| includer.options[this.name]['buildTarget']; |
There was a problem hiding this comment.
Updating the reference to keep things consistent.
jrowlingson
changed the title
jrowlingson
changed the title
|
Awesome! If you are feeling inclined, you could use Mirage's node tests as a reference for how to test the tree in each environment. (Mirage does something similar where it doesn't ship itself in If you don't think you'll have time, just let me know and we can punt on this for now. Thanks! |
|
Thanks for the example! I have added a few tests to cover this option. |
|
✨ Amazing ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17
Addresses part 1 of 2 (don't
app.import('etw.css'))It was unclear to me how to best approach a test for this particular change so I have opted to omit.