useEffect for the POST
#1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
any side-effects should happen in a `useEffect` hook. This commit does that by creating a new hook which does the posting to a server, resetting of the todo input, and focusing of the `inputEl`. The [dependencies array](https://reactjs.org/docs/hooks-reference.html#conditionally-firing-an-effect) specifies that whenever the `isSaving` state changes, this effect should execute. That's only half of the story here. We additionally check _inside_ of the hook that the value of `isSaving` is `true`. Then and only then do we go ahead with the post. You'll also notice that I'm not specifying `newTodo` in the dependency array. That's because I don't need this effect to run every time the value is updated, only when it's submitted.
|
still not convinced dawg 😄 In all honesty this reminds me of observers from Ember. The one-way flow from event to action still feels safer to me... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
any side-effects should happen in a
useEffecthook. This commit does that by creating a new hook which does the posting to a server, resetting of the todo input, and focusing of theinputEl.The dependencies array specifies that whenever the
isSavingstate changes, this effect should execute. That's only half of the story here.We additionally check inside of the hook that the value of
isSavingistrue. Then and only then do we go ahead with the post. You'll also notice that I'm not specifyingnewTodoin the dependency array. That's because I don't need this effect to run every time the value is updated, only when it's submitted.