Fix binary asset support in keepAssets #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in #2156 broke formatting of binary kept assets, because rollup's default load hook will corrupt them. This provides our own load hook again. But it's still OK to put this plugin after another plugin with a custom load hook, in which case we will take over starting at the `transform` stage instead. In that case, it's up to the other plugin's load hook to produce valid UTF8.
ef4
force-pushed
the
binary-keep-assets
branch
from
ce177e4 to
ce7e688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #2156 broke formatting of binary kept assets, because rollup's default load hook will corrupt them.
This provides our own load hook again. But it's still OK to put this plugin after another plugin with a custom load hook, in which case we will take over starting at the
transformstage instead. In that case, it's up to the other plugin's load hook to produce valid UTF8.