Fix setup.py to release based on git tag #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isi-adas
force-pushed
the
BR_FIX_SETUP_PY
branch
from
172155a to
97aa704
Compare
siddiw
approved these changes
Aug 16, 2024
isi-adas
force-pushed
the
BR_FIX_SETUP_PY
branch
from
97aa704 to
a49f7a3
Compare
siddiw
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part will help in releasing the package.
NOTE: localsetup.py is a copy of setup.py with git tag used for release.
Tested by going to pike folder and running
python3 ./localsetup.py dist...
...
Writing pike-smb2-0.4.5/setup.cfg
Creating tar archive
This will be followed by
twine upload dist/pike-smb2-0.4.5.tar.gzCC: @sudosantanu @marchhare09 @siddiw @sgovind