Skip to content

Commit

Permalink
Expand tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Scienfitz committed Sep 5, 2024
1 parent bcb68d3 commit e8c9658
Showing 1 changed file with 32 additions and 2 deletions.
34 changes: 32 additions & 2 deletions tests/test_pending_experiments.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,17 @@
_flags = dict(
allow_repeated_recommendations=True,
allow_recommending_already_measured=True,
allow_recommending_pending_experiments=False,
)


@pytest.mark.parametrize(
"parameter_names, recommender",
[
param(_discrete_params, FPSRecommender(**_flags), id="fps_discrete"),
param(
_discrete_params,
FPSRecommender(**_flags),
id="fps_discrete",
),
param(_discrete_params, PAMClusteringRecommender(**_flags), id="pam_discrete"),
param(
_discrete_params,
Expand All @@ -64,6 +67,33 @@
TwoPhaseMetaRecommender(recommender=BotorchRecommender(**_flags)),
id="botorch_hybrid",
),
param(
_discrete_params,
TwoPhaseMetaRecommender(
recommender=BotorchRecommender(
**_flags, allow_recommending_pending_experiments=True
)
),
id="botorch_discrete_allow",
),
param(
_continuous_params,
TwoPhaseMetaRecommender(
recommender=BotorchRecommender(
**_flags, allow_recommending_pending_experiments=True
)
),
id="botorch_continuous_allow",
),
param(
_hybrid_params,
TwoPhaseMetaRecommender(
recommender=BotorchRecommender(
**_flags, allow_recommending_pending_experiments=True
)
),
id="botorch_hybrid_allow",
),
param(
_discrete_params,
NaiveHybridSpaceRecommender(
Expand Down

0 comments on commit e8c9658

Please sign in to comment.