-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework validation for measurements
and pending_experiments
#456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Scienfitz, thanks the refactor 🏗️ Below my comments
0a42492
to
a412305
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7056db6
to
969dea4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
326a1b5
to
d1f4c50
Compare
Co-authored-by: AdrianSosic <adrian.sosic@merckgroup.com>
107e225
to
c3ffc9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of very minor comments, you'll still get a full review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So now here's finally your full review 🙃
Co-authored-by: AdrianSosic <adrian.sosic@merckgroup.com>
cddbee4
to
bb5a8d6
Compare
Fixes #453
Notes re
measurements
validationadd_measurements
andfuzzy_row_match
fuzzy_row_match
does not perform any validation anymore. Whether numerical parameter measurements outside of numerical tolerances are allowed is now decided by outside of this function, it will always match numerical parts on the smallest distanceadd_measurements
now simply calls the utilitiesValidatedDataFrame
Notes re
pending_experiments
validationCampaign.recommend
now performs validation ofpending_experiments
pending_experiments
have been addedNotes on recommenders
measurements
andpending_experiments
inrecommend
measurements
andpending_experiments
because the validation needs to happen before the call to the base classNotes on
numerical_measurements_must_be_within_tolerance
measurements
inCampaign.add_measurements
pending_experiments
are always valid independent of any numerical tolerance deviation (both in recommenders and campaign) and ii)measurements
are always valid independent of numerical tolerances for recommenders