Skip to content

Commit

Permalink
publish
Browse files Browse the repository at this point in the history
  • Loading branch information
eddow committed Nov 6, 2024
1 parent 77d35bf commit 4a1fa78
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,7 @@ For the library, a class implementing another without going through the `Diamond

The only problem still worked on is that if a class who has no implementation for an abstract method appears before another one who has an implementation, the method will be considered abstract (so the order of arguments for `Diamond(...)` matters here), even though a `//@ts-ignore` does the job.

> :arrow_up: Btw, if someone could help me here... It's on `HasBases` type definition

> Note: [It seems impossible...](https://stackoverflow.com/questions/79149281/complex-types-definition-abstract-method-filter)
> Note: [It seems impossible to solve...](https://stackoverflow.com/questions/79149281/complex-types-definition-abstract-method-filter)

### Constructor parameters

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "flat-diamond",
"version": "1.0.9",
"version": "1.0.10",
"types": "./lib/index.d.ts",
"exports": {
".": {
Expand Down
2 changes: 2 additions & 0 deletions src/seclude.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ export function Seclude<TBase extends Ctor, Keys extends (keyof InstanceType<TBa
}
}
// In order to be treated as a function (to retrieve the private part), we have to use yet another proxy
// Making `GateKeeper` as a function directly and setting its prototype to `diamond` does not allow
// `super(...)` equivalent
const GateKeeperProxy = new Proxy(GateKeeper, {
apply(target, thisArg, argArray) {
return privates.get(argArray[0])
Expand Down

0 comments on commit 4a1fa78

Please sign in to comment.