[NEW # 4949001] Ported latest articles cms plugin as package #1
Conversation
…kage [NEW] Add CI/CD workflows from firm_info and update with django and cms in test with tox [NEW] Add issues templates from cms_plugin_blocks [NEW] Add sphinx doc and config: [CHG] Update tests to pass tox AssertQuerySetEqual and AssertQuerysetEqual were not adequate for older/newer versions Update codeQL workflow to run on pull_request on dev branch
|
I'll update this portion of setup.cfg on monday: [options.package_data] |
| - Plateform: Window/IOS/Linux distribution | ||
| - Python version: | ||
| - Django version: | ||
|
|
There was a problem hiding this comment.
Add lines for "Lotus version" and "Lotus CMS plugin version"
.readthedocs.yml
Outdated
| # Optionally set the version of Python and requirements required to build your docs | ||
| python: | ||
| install: | ||
| - requirements: docs/requirements.txt |
There was a problem hiding this comment.
Usage of docs requirements is deprecated because it blocks you to test doc building on RTD on a non release version (the requirements file would want to install a packaged release only but RTD is able to build from any branch independently of package).
We prefer this way https://github.com/sveetch/py-css-styleguide/blob/master/.readthedocs.yml#L20 that only relate to "checkouted" branch, directly using the setup extra requirements.
MANIFEST.in
Outdated
| include LICENCE.txt | ||
| include README.rst | ||
|
|
||
| exclude sphinx_reload.py |
There was a problem hiding this comment.
Removed 5 first lines in fb3e044
| @echo | ||
| @echo " freeze-dependencies -- to write installed dependencies versions in frozen.txt" | ||
| @echo " install -- to install this project with virtualenv and Pip" | ||
| @echo |
There was a problem hiding this comment.
Your makefile seems coming from Python package cookiecutter which does not include any Django related stuff like tasks migrate, check-migration, check-django, migrations, po, mo, etc..
| Dependencies | ||
| ************ | ||
|
|
||
| * `Python`_>=3.8; |
There was a problem hiding this comment.
Missing dependencies for Django and DjangoCMS since there are essential dependencies that are important to announce.
| "treebeard", | ||
| "menus", | ||
| "sekizai", | ||
| "lotus", |
There was a problem hiding this comment.
Lotus apps and settings should be in its own part below to avoid confusion with the DjangoCMS requirements.
| (TEST_PAGE_TEMPLATES, "test-basic"), | ||
| ) | ||
|
|
||
| BLOCKS_LOTUS_PLUGIN_TEMPLATES = [ |
There was a problem hiding this comment.
This is not a block (from cmsplugin-blocks), this is lotus plugin, so LOTUS_CMSPLUGIN_TEMPLATES
| install_requires = | ||
| django-cms>=3.11.0 | ||
| django-blog-lotus[breadcrumbs]==0.7.0 | ||
| django-autocomplete-light>=3.9.7 |
There was a problem hiding this comment.
This is already defined from Lotus setup, don't enforce anything, this is Lotus that should manage this. Also you may relax lotus version requirement else you will have to make a new dummy release each time a new Lotus is released.
|
|
||
| [tox:tox] | ||
| minversion = 3.4.0 | ||
| envlist = py{38,310}-django{32,40,41,42}-cms{311} |
There was a problem hiding this comment.
Don't test every case, only the bounds else the tox run will be very long to finish. Bound versions are sufficient enough except for very exotic issue that are not worth to slow down quality process.
@sveetch Could you provide a list of essential/nice to have improvements on following subjects:
If you have any other suggestion, please advise.
NB: You might differentiate what is critical, from TODO.