Return validation options and fix gas validator (#553)

emeraldpay · Aug 22, 2024 · a8b91fa · a8b91fa
1 parent 3d9193e
commit a8b91fa
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/foundation/src/main/kotlin/io/emeraldpay/dshackle/foundation/ChainOptionsReader.kt b/foundation/src/main/kotlin/io/emeraldpay/dshackle/foundation/ChainOptionsReader.kt
@@ -49,6 +49,9 @@ class ChainOptionsReader : YamlConfigReader<ChainOptions.PartialOptions>() {
         getValueAsInt(values, "call-limit-size")?.let {
             options.callLimitSize = it
         }
+        getValueAsBool(values, "disable-upstream-validation")?.let {
+            options.disableUpstreamValidation = it
+        }
         return options
     }
 }
diff --git a/src/main/kotlin/io/emeraldpay/dshackle/upstream/ethereum/EthereumChainSpecific.kt b/src/main/kotlin/io/emeraldpay/dshackle/upstream/ethereum/EthereumChainSpecific.kt
@@ -155,15 +155,18 @@ object EthereumChainSpecific : AbstractPollChainSpecific() {
     ): List<SingleValidator<ValidateUpstreamSettingsResult>> {
         val limitValidator = callLimitValidatorFactory(upstream, options, config, chain)
 
-        return listOf(
+        val validators = mutableListOf(
             ChainIdValidator(upstream, chain),
             OldBlockValidator(upstream),
-            GasPriceValidator(upstream, config),
-        ) + if (limitValidator.isEnabled()) {
-            listOf(limitValidator)
-        } else {
-            emptyList()
+        )
+        if (limitValidator.isEnabled()) {
+            validators.add(limitValidator)
         }
+        if (options.validateGasPrice) {
+            validators.add(GasPriceValidator(upstream, config))
+        }
+
+        return validators
     }
 
     override fun chainSettingsValidator(

diff --git a/src/main/kotlin/io/emeraldpay/dshackle/upstream/ethereum/EthereumUpstreamValidator.kt b/src/main/kotlin/io/emeraldpay/dshackle/upstream/ethereum/EthereumUpstreamValidator.kt
@@ -267,6 +267,9 @@ class GasPriceValidator(
         val log: Logger = LoggerFactory.getLogger(GasPriceValidator::class.java)
     }
     override fun validate(onError: ValidateUpstreamSettingsResult): Mono<ValidateUpstreamSettingsResult> {
+        if (!upstream.getMethods().isCallable("eth_gasPrice")) {
+            return Mono.just(ValidateUpstreamSettingsResult.UPSTREAM_VALID)
+        }
         return upstream.getIngressReader()
             .read(ChainRequest("eth_gasPrice", ListParams()))
             .flatMap(ChainResponse::requireStringResult)