Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem: no metrics enabled for file based log #263

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

splix
Copy link
Member

@splix splix commented Oct 3, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (f4de5cc) 57.78% compared to head (47aa491) 57.81%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #263      +/-   ##
============================================
+ Coverage     57.78%   57.81%   +0.02%     
- Complexity     1752     1755       +3     
============================================
  Files           274      274              
  Lines          9642     9655      +13     
  Branches       1189     1189              
============================================
+ Hits           5572     5582      +10     
- Misses         3429     3432       +3     
  Partials        641      641              
Files Coverage Δ
...eraldpay/dshackle/monitoring/BufferingLogWriter.kt 86.04% <100.00%> (+0.68%) ⬆️
...io/emeraldpay/dshackle/monitoring/FileLogWriter.kt 71.42% <100.00%> (+0.51%) ⬆️
...emeraldpay/dshackle/monitoring/CurrentLogWriter.kt 80.00% <71.42%> (+1.62%) ⬆️
...in/io/emeraldpay/dshackle/monitoring/LogMetrics.kt 8.33% <10.00%> (+2.45%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splix splix merged commit 35c94db into master Oct 3, 2023
2 checks passed
@splix splix deleted the fix/no-metrics-file-logs branch October 3, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants