Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dockerfile support #279

Closed
wants to merge 3 commits into from

Conversation

barnabasbusa
Copy link

@barnabasbusa barnabasbusa commented Dec 18, 2023

Closes: #277

@CLAassistant
Copy link

CLAassistant commented Dec 18, 2023

CLA assistant check
All committers have signed the CLA.

@splix
Copy link
Member

splix commented Dec 18, 2023

@barnabasbusa let me think about this.

Having a Dockerfile seems to be a very confusing for Java developers, because it's expected to use Jib plugin, which is configured in Gradle. So I'm trying to figure out if it's possible to make a one liner instead of a whole Dockerfile.

Anyway, wanted to ask about your use case for this. Because as I see it, for anyone who changes the code it's a non-issues because he would definitely have a JVM or JDK installed. For others, who don't change the code, there is a CI action that makes a public build after each commit into master branch. Can you tell me more what you're trying reach? Here, or on Discord. Thank you

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fd701b) 57.98% compared to head (88e20d1) 57.98%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #279   +/-   ##
=========================================
  Coverage     57.98%   57.98%           
  Complexity     1801     1801           
=========================================
  Files           278      278           
  Lines          9823     9823           
  Branches       1227     1227           
=========================================
  Hits           5696     5696           
  Misses         3461     3461           
  Partials        666      666           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Add a Dockerfile
4 participants