Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem: upstreams may produce blocks with a heavy delay and replace … #284

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

splix
Copy link
Member

@splix splix commented Mar 29, 2024

…existing head with an older block

solution: order conflicting head blocks by difficulty on PoW and priority on PoS

…existing head with an older block

solution: order conflicting head blocks by difficulty on PoW and priority on PoS
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 65.83333% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 58.16%. Comparing base (d379d5d) to head (16768d0).

Files Patch % Lines
...n/io/emeraldpay/dshackle/upstream/MergedPosHead.kt 66.07% 13 Missing and 6 partials ⚠️
...n/io/emeraldpay/dshackle/upstream/MergedPowHead.kt 67.30% 10 Missing and 7 partials ⚠️
.../dshackle/upstream/ethereum/EthereumMultistream.kt 77.77% 1 Missing and 1 partial ⚠️
...emeraldpay/dshackle/startup/ConfiguredUpstreams.kt 0.00% 1 Missing ⚠️
...ay/dshackle/upstream/bitcoin/BitcoinMultistream.kt 0.00% 1 Missing ⚠️
.../dshackle/upstream/ethereum/EthereumRpcUpstream.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #284      +/-   ##
============================================
+ Coverage     58.01%   58.16%   +0.15%     
- Complexity     1803     1844      +41     
============================================
  Files           278      279       +1     
  Lines          9839     9937      +98     
  Branches       1231     1262      +31     
============================================
+ Hits           5708     5780      +72     
- Misses         3465     3479      +14     
- Partials        666      678      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splix splix merged commit c9e760c into master Mar 29, 2024
3 checks passed
@splix splix deleted the fix/unstable-head-block branch March 29, 2024 22:11
splix pushed a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants