strip the prefix from ipv4-mapped addresses #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is cool! I think it's a good idea, but I feel like some test cases for it might be a good idea. I'm also not 100% sure that it's safe under all circumstances. At first glance it certainly looks fine, though. Just my two cents. |
|
I could not come up with a situation that could cause trouble... But yes, looks too easy to be real. 😜 |
emikulic
reviewed
Jan 25, 2025
|
Could you please give me an example of how this looks? I guess in the access log? |
eworm-de
force-pushed
the
strip-mapped
branch
from
ffcc08e to
c1dcc8a
Compare
|
Yes, this is for access log. Before: After: |
eworm-de
force-pushed
the
strip-mapped
branch
2 times, most recently
from
e3c12c4 to
0793a4b
Compare
|
Updated again... There's a macro |
eworm-de
force-pushed
the
strip-mapped
branch
2 times, most recently
from
ac48ad1 to
9e5738c
Compare
... to use it again later.
This allows to have plain IPv4 addresses in log, even if listening
on an IPv6 socket.
Before:
::ffff:10.7.7.72 - - [24/Jan/2025:22:15:54 +0100] "GET /archive.tar.zst HTTP/1.1" 200 72194 "" "pacredir/0.4.8 (arch/x86_64)"
After:
10.7.7.72 - - [24/Jan/2025:22:15:54 +0100] "GET /archive.tar.zst HTTP/1.1" 200 72194 "" "pacredir/0.4.8 (arch/x86_64)"
eworm-de
force-pushed
the
strip-mapped
branch
from
9e5738c to
81badcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to have plain IPv4 addresses in log, even if listening on an IPv6 socket.