Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated std::aligned_storage & std::aligned_union #325

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

marcushultman
Copy link

@marcushultman marcushultman commented Apr 4, 2024

Deprecated in C++23
See cplusplus/papers#197

@marcushultman marcushultman force-pushed the aligned-storage-patch branch 4 times, most recently from 3fc7580 to 7fcccb3 Compare April 4, 2024 23:09
@marcushultman marcushultman force-pushed the aligned-storage-patch branch 6 times, most recently from 5c2b54a to b1f15e4 Compare June 20, 2024 19:25
@marcushultman marcushultman force-pushed the aligned-storage-patch branch from b1f15e4 to 193e0d7 Compare June 21, 2024 00:53
@marcushultman marcushultman force-pushed the aligned-storage-patch branch from 193e0d7 to 3528749 Compare June 21, 2024 01:32
@marcushultman
Copy link
Author

@emil-e I ran in to nasty Compiler Error C2718 for the MSVC x86 compiler you run in CI, but I think I managed to remove the places where a Variant is passed by value as a function parameter. I believe you could also stop building for 32-bit windows and the problem would go away.

@marcushultman
Copy link
Author

Ping @emil-e :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant