Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sizing bug in TextEdit::singleline #5640

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix sizing bug in TextEdit::singleline #5640

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5686c35
Remove buggy TextEdit scroll fix (#5500, #5597)
IaVashik Jan 26, 2025
903a88d
Unused import was removed
IaVashik Jan 27, 2025
3a030d7
Restore TextArea size fix, conditional on !clip_text
IaVashik Jan 27, 2025
bab8828
Update Code Example snapshot
IaVashik Feb 5, 2025
adde2b0
Merge branch 'master' into master
IaVashik Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions crates/egui/src/widgets/text_edit/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,16 +723,6 @@ impl TextEdit<'_> {
}
}

// Allocate additional space if edits were made this frame that changed the size. This is important so that,
// if there's a ScrollArea, it can properly scroll to the cursor.
let extra_size = galley.size() - rect.size();
if extra_size.x > 0.0 || extra_size.y > 0.0 {
ui.allocate_rect(
Rect::from_min_size(outer_rect.max, extra_size),
Sense::hover(),
);
}

painter.galley(galley_pos, galley.clone(), text_color);

if has_focus {
Expand Down
Loading