Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade base image to Ubuntu 20.04 #134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Upgrade base image to Ubuntu 20.04 #134

wants to merge 2 commits into from

Conversation

emk
Copy link
Owner

@emk emk commented Jan 1, 2022

Many thanks to @asaaki for having figured out the static link check was
returning flase negatives with Alpine's lld. See:

#120 (comment)

The plan is to merge this when Rust 1.58.0 is released, so people who
need 18.04 can stick with1.57.0.

Closes #98.
Closes #120.

Many thanks to @asaaki for having figured out the static link check was
returning flase negatives with Alpine's `lld`. See:

#120 (comment)

The plan is to merge this when Rust 1.58.0 is released, so people who
need 18.04 can stick with1.57.0.

Closes #98.
Closes #120.
This was referenced Jan 1, 2022
@emk emk changed the title Upgrade baseimage to Ubuntu 20.04 Upgrade base image to Ubuntu 20.04 Jan 1, 2022
@satmandu
Copy link

satmandu commented Feb 1, 2022

Now that 1.58.1 is out...

@hoijui
Copy link

hoijui commented Mar 19, 2022

This is also required to be able to use this container as a base for GitHub Actions, because the checkout action, which is almost always the first action of any build run, requires a newer version of git then is available in Ubuntu 18.04.

@hoijui
Copy link

hoijui commented Mar 25, 2022

Solution for GitHub Actions:
Don't use this docker image, but the normal actions-rs/toolchain action you also use for non-MUSL building, and just add the target property like so:

      - name: "Get the Rust toolchain"
         uses: actions-rs/toolchain@v1
         with:
             toolchain: stable
             override: true
             target: x86_64-unknown-linux-musl
             components: rustfmt, clippy

      - name: "Build manual"
        run: cargo build --verbose --release --target=x86_64-unknown-linux-musl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu 20.04
3 participants