fix: enhance lint and type checks in github actions

emnnipal · Nov 27, 2022 · 816bb95 · 816bb95
1 parent 3d640a7
commit 816bb95
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 29 deletions.
diff --git a/.github/workflows/deploy-workflow.yml b/.github/workflows/deploy-workflow.yml
@@ -29,11 +29,8 @@ jobs:
       - name: Install dependencies
         run: pnpm install --frozen-lockfile --ignore-scripts
 
-      - name: Check Types
-        run: pnpm check:types
-
-      - name: Run ESLint
-        run: pnpm lint
+      - name: Run lint and type checks
+        run: pnpm lint & pnpm check:types & wait
 
       - name: Run tests
         run: pnpm test -- --maxWorkers=4 --no-color --coverage=false --changedSince=origin/main

diff --git a/.github/workflows/pr-tests.yml b/.github/workflows/pr-tests.yml
@@ -23,30 +23,8 @@ jobs:
       - name: Install dependencies
         run: pnpm install --frozen-lockfile --ignore-scripts
 
-      - name: Run ESLint
-        run: pnpm lint
+      - name: Run lint and type checks
+        run: pnpm lint & pnpm check:types & wait
 
       - name: Run tests
         run: pnpm test -- --maxWorkers=4 --no-color --coverage=false --changedSince=origin/main
-
-  pr-check-types:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v3
-        with:
-          ref: ${{ github.ref }}
-
-      - uses: pnpm/[email protected]
-        with:
-          version: 7.0.1
-
-      - uses: actions/setup-node@v2
-        with:
-          node-version: 16.13.0
-          cache: 'pnpm'
-
-      - name: Install dependencies
-        run: pnpm install --frozen-lockfile --ignore-scripts
-
-      - name: Check Types
-        run: pnpm check:types