Work on a take api #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take will take audio out of the session audio buffer and adjust the start time of the segments to match - this is mostly for compat/UX. The main focus of this is to allow someone to evacuate some audio and shorten existing segments in case they're accruing an ever larger vector of audio samples while someone is nattering on. I also did some cleanup of the code mainly: 1. speech_end_ms was only set in one place and set to `None` at the end of the block 2. Move out duration -> index into separate methods and add a panicking and non-panicking version 3. Fix the bad asserts in `get_current_audio` where underflow could mess things up
WenqingZong
approved these changes
Nov 22, 2024
blueridanus
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A potential approach for #31 this provides an API so users can do a thing
Take will take audio out of the session audio buffer and adjust the start time of the segments to match - this is mostly for compat/UX. The main focus of this is to allow someone to evacuate some audio and shorten existing segments in case they're accruing an ever larger vector of audio samples while someone is nattering on.
I also did some cleanup of the code mainly:
Noneat the end of the blockget_current_audiowhere underflow could mess things up