refactor(limiter): refactor and simplify the limiter #14475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafirest
force-pushed
the
refactor/limiter
branch
8 times, most recently
from
6afd0a9 to
f0c46c3
Compare
ieQu1
reviewed
Jan 2, 2025
lafirest
force-pushed
the
refactor/limiter
branch
from
f0c46c3 to
e8a71dc
Compare
lafirest
commented
Jan 9, 2025
zmstone
reviewed
Jan 9, 2025
Comment on lines
+51
to
+55
| -callback check(non_neg_integer(), limiter()) -> {boolean(), limiter()}. | ||
| -callback restore(non_neg_integer(), limiter()) -> limiter(). |
| bucket_ref() | ||
| ) -> boolean(). | ||
| insert_bucket(Id, Type, Bucket) -> | ||
| insert_bucket(Zone, Name, Bucket) -> |
There was a problem hiding this comment.
store in persistent term for hot config update.
lafirest
force-pushed
the
refactor/limiter
branch
from
e8a71dc to
8eba8a5
Compare
lafirest
force-pushed
the
refactor/limiter
branch
from
8eba8a5 to
2afee25
Compare
lafirest
force-pushed
the
refactor/limiter
branch
from
2afee25 to
b568775
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-13124
Release version: v/e5.9.0
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update