Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix modbus #2245 and reorder #2220 #2246

Merged
merged 4 commits into from
Nov 24, 2024
Merged

fix modbus #2245 and reorder #2220 #2246

merged 4 commits into from
Nov 24, 2024

Conversation

MichaelDvP
Copy link
Contributor

I have only removed the SM100 water from modbus. Has to be generated again, but still can't compile in wsl, mybe my laptop has too low resources.

@proddy
Copy link
Contributor

proddy commented Nov 24, 2024

I can do the generation thing. Maybe it should be part of the CI scripts to automatically rebuild the files and check-them in.

Or if you can get pio native to work on Windows (not WSL) we can adjust the .sh shell script to work with PowerShell.

WSL2 is a monster - it uses up to 7GB memory on my desktop PC so I can imagine it's awful on a windows laptop. I know BBQKees had a lot of issues too running on chrome laptops. In the end it was just easier to install Linux as a separate OS on the laptop and switch between the two at boot

@proddy proddy merged commit 4e5ad82 into emsesp:dev Nov 24, 2024
1 check passed
@MichaelDvP
Copy link
Contributor Author

Yes, windows native compile works good, To generate the modbus in powershell and/or github would be fine.

BTW: i renamed one of he ISM modules to ISM2, the csv put both ISM under one headline, looks a bit odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants