Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WRR-6380: Converted Popup/Popup to functional component #1734

Open
wants to merge 32 commits into
base: develop
Choose a base branch
from
Open

WRR-6380: Converted Popup/Popup to functional component #1734

wants to merge 32 commits into from

Commits on Oct 16, 2024

  1. Converted Popup to functional component

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    69c9bbb View commit details
    Browse the repository at this point in the history

  2. Fixed lint warnings

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e5cfb74 View commit details
    Browse the repository at this point in the history

  3. Deleted ...rest props

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    2f72395 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Fixed focus issues

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    cc86ba6 View commit details
    Browse the repository at this point in the history

  2. Fixed cleanup function

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    91ce7aa View commit details
    Browse the repository at this point in the history

  3. Fixed lint warnings

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    95494c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Extracted props from handleKeyDown

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    461e1a4 View commit details
    Browse the repository at this point in the history

  2. Code refactor

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2e5c79d View commit details
    Browse the repository at this point in the history

  3. Added target for the on and off listeners

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    88aaee4 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Created reference for handleKeyDown function

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    f36c087 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Created reference for containerId only when component is mounted

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d51f921 View commit details
    Browse the repository at this point in the history

  2. Component refactor

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b562900 View commit details
    Browse the repository at this point in the history

  3. Added useEffect to spot the Popup content after it's mounted and open

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    0426396 View commit details
    Browse the repository at this point in the history

  4. Added default value for containerId

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    96a62b4 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Added Pause class in useState instead of useRef

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c3a3ade View commit details
    Browse the repository at this point in the history

  2. Changed condition for spotActivator

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c9ca422 View commit details
    Browse the repository at this point in the history

  3. Changed condition for spotActivator

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    293f95c View commit details
    Browse the repository at this point in the history

  4. Fixed lint warnings

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1729bb7 View commit details
    Browse the repository at this point in the history

  5. Moved Pause class into useRef

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    5c06c2f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' of https://github.com/enactjs/sandstone into f… 

    …eature/WRR-6380
    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ad7008b View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Fixed focus issues on Popup and refactored the code

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a1a2e85 View commit details
    Browse the repository at this point in the history

  2. Fixed focus issues on Input

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    8d29d81 View commit details
    Browse the repository at this point in the history

  3. Forced Spotlight to focus the last focused element when the Popup… 

    … is closed
    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    36162d3 View commit details
    Browse the repository at this point in the history

  4. Fixed lint warnings

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    4f96a9c View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Added condition to focus activator when the Popup is closed and r… 

    …emoved unnecessary `useEffect`
    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    421211b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' of https://github.com/enactjs/sandstone into f… 

    …eature/WRR-6380
    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2bb8941 View commit details
    Browse the repository at this point in the history

  3. Changed the comment for handleComponentUpdate function

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    120af63 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Review fixes

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    7b5e6c7 View commit details
    Browse the repository at this point in the history

  2. Review fixes

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ddd7a63 View commit details
    Browse the repository at this point in the history

  3. Fixed lint warnings

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    19935d1 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Review fixes

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    93c8dcb View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Fixed eventListeners

    @ion-andrusciac-lgp
    ion-andrusciac-lgp committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    5b0556d View commit details
    Browse the repository at this point in the history