-
Notifications
You must be signed in to change notification settings - Fork 14
Added webinterface option for C++ chat client, small Rust config changes #70
Conversation
A better way to do things might have been to rebase #69 and update.
Also, you should probably work in a new branch instead of
If you have any questions, let me know, or ask in the Enarx chat. A tutorial: https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase |
Would it be OK to merge this PR as it is now or should I add it all to a new branch? Was trying to squash all the commits into one but didn't get it right |
Don't worry about having a new branch this time. It seems one of the checks is failing because |
I've it fixed on local, was using your python script to generate the webpage assets but didn't realise it'd break something so I've included it. I'll upload final commit now and solve merge issues |
That's fine for now, but the Nix code should be updated to generate |
Ah ok, I'll look into Nix, haven't used it before |
1cb75a1
to
9a96e63
Compare
Hi @kieranjazy, I tested your PR and it works great. Thanks! |
Thanks Nick, just struggling to get Nix to run a Python script for me, still working on it |
I don't think we need that, at least it should not be a blocker for this PR, this warrants more discussion. Can we file a "goldplating" tech debt issue about it and get this merged? |
d5c539c
to
e88569b
Compare
@kieranjazy I believe the outdated
|
Added C++ web interface available by default. Can be disabled by removing --webinterface from Enarx.toml. Uses port 8080. Made small changes to Rust files to fix broken file locations