persist request state into asgi scope extension #1479
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible solution for #495
Not sure this is the best way to do it, it isn't particularly nice, and I can think of other ways to do it.
Some ideas:
class RequestState
(maybe typing.SimpleNamespace?) and store that in the extension so we assign 1 attribute instead of replacing dictTypedDict
On the other hand, I think this works for all cases (e.g. creating an
HTTPConnection
first then aRequest
or the other way around should work just fine since Request is a subclass of HTTPConnection and thus the mismatched attributes are strictly extra not overlapping)I'm also not 100% sure this is valid ASGI, the spec is pretty brief on the extensions thing.