CORS-middleware-use-explicit-origin-with-credentials #2119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you clarify what this is and link to an issue? Otherwise we’ll have to close this PR |
|
Hi Adrian,
I am new to open source and this is my first issue. I was trying to solve
the issue discussed here: #1832
I spoke to Marcelo regarding this, and I have understood I need to
investigate more on this
…On Wed, 12 Apr 2023 at 21:48, Adrian Garcia Badaracco < ***@***.***> wrote:
Can you clarify what this is and link to an issue? Otherwise we’ll have to
close this PR
—
Reply to this email directly, view it on GitHub
<#2119 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD6X453FT33FWFGPNOEDZFLXA4BHTANCNFSM6AAAAAAW4AADVU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Please change the title to something more suitable, add a better description, and as I said before: I need to reread the issue, and we need to know what's the behavior of the others web frameworks (flask, django, and maybe others because I believe those two differ in this particular point). |
Swati-Sneha
changed the title
|
@Swati-Sneha Are you still interested in this? 👀 |
|
@Swati-Sneha I'll be closing this for the time being, feel free to reopen based on our comments. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The starting point for contributions should usually be 1832
Simple documentation typos may be raised as stand-alone pull requests, but otherwise please ensure you've discussed your proposal prior to issuing a pull request.
This will help us direct work appropriately, and ensure that any suggested changes have been okayed by the maintainers.