-
-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name changes #55
Name changes #55
Conversation
@@ -1,44 +1,44 @@ | |||
|
|||
Starlette includes a `View` class that provides a class-based view pattern which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Best rename the docs file too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff.
Let's rename the views.md
file, and also bring in the other changes discussed at the same time. WebSocketSession
-> WebSocket
, session
-> websocket
when it is used as a variable. requests.py
, responses.py
We'll want to make all these in a single version bump.
Something else I'd also like to see us do as part of this, would be to always use full module imports in the source and tests, and drop imports from |
9a80dfd
to
8952bb3
Compare
Update the PR with the additional changes:
|
Okay, let's go for it. |
Refs #51
Renames
View
class ->HTTPEndpoint
andApp
class ->Starlette
.There were some other name change suggestions on the ticket as well, but these two seemed like the most obvious ones to start with. I can add the other name changes to this PR as well, but figured it would be better to open it up to discussion first.
I think this makes sense.
These I'm not as sure about - haven't looked at them enough to have an opinion either way at this point.