Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade websockets to 0.13.1 #2471

Merged
merged 2 commits into from
Sep 28, 2024
Merged

Upgrade websockets to 0.13.1 #2471

merged 2 commits into from
Sep 28, 2024

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Sep 28, 2024

This pull request includes several changes to the uvicorn project, focusing on handling deprecation warnings and refining the WebSocket protocol implementation. The key changes involve the addition of a new filter warning, adjustments to method signatures, and improvements to exception handling in WebSocket communication.

Handling Deprecation Warnings:

  • pyproject.toml: Added a new deprecation warning filter for the websockets library. ([pyproject.tomlR99](https://github.com/encode/uvicorn/pull/2471/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R99))

WebSocket Protocol Implementation:

  • uvicorn/protocols/websockets/websockets_impl.py:
    • Simplified the ws_handler method signature by removing the multi-line format. ([uvicorn/protocols/websockets/websockets_impl.pyL227-R227](https://github.com/encode/uvicorn/pull/2471/files#diff-74255e578d2ca222f3b49857a51f2a81a9228f598393e53ba4658da913931729L227-R227))
    • Streamlined the asgi_receive method signature for better readability. ([uvicorn/protocols/websockets/websockets_impl.pyL362-R360](https://github.com/encode/uvicorn/pull/2471/files#diff-74255e578d2ca222f3b49857a51f2a81a9228f598393e53ba4658da913931729L362-R360))
    • Improved exception handling in the asgi_receive method to use self.close_code and self.close_reason instead of the exception attributes. ([uvicorn/protocols/websockets/websockets_impl.pyL381-R381](https://github.com/encode/uvicorn/pull/2471/files#diff-74255e578d2ca222f3b49857a51f2a81a9228f598393e53ba4658da913931729L381-R381))

@Kludex
Copy link
Member Author

Kludex commented Sep 28, 2024

This copilot summary is not that helpful.

I've bumped the websockets in the test suite. I also made sure uvicorn continues to work on the minimum version set on the pyproject i.e. 10.4.

I've also added more type hints to the test_websockets.py.

@Kludex Kludex enabled auto-merge (squash) September 28, 2024 15:10
@Kludex Kludex merged commit c7668ce into master Sep 28, 2024
15 checks passed
@Kludex Kludex deleted the update-websockets branch September 28, 2024 15:11
raf-moreau pushed a commit to raf-moreau/uvicorn that referenced this pull request Nov 5, 2024
* Upgrade websockets to 0.13.1

* Send 1005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant