Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
uvicorn
project, focusing on handling deprecation warnings and refining the WebSocket protocol implementation. The key changes involve the addition of a new filter warning, adjustments to method signatures, and improvements to exception handling in WebSocket communication.Handling Deprecation Warnings:
pyproject.toml
: Added a new deprecation warning filter for thewebsockets
library. ([pyproject.tomlR99](https://github.com/encode/uvicorn/pull/2471/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R99)
)WebSocket Protocol Implementation:
uvicorn/protocols/websockets/websockets_impl.py
:ws_handler
method signature by removing the multi-line format. ([uvicorn/protocols/websockets/websockets_impl.pyL227-R227](https://github.com/encode/uvicorn/pull/2471/files#diff-74255e578d2ca222f3b49857a51f2a81a9228f598393e53ba4658da913931729L227-R227)
)asgi_receive
method signature for better readability. ([uvicorn/protocols/websockets/websockets_impl.pyL362-R360](https://github.com/encode/uvicorn/pull/2471/files#diff-74255e578d2ca222f3b49857a51f2a81a9228f598393e53ba4658da913931729L362-R360)
)asgi_receive
method to useself.close_code
andself.close_reason
instead of the exception attributes. ([uvicorn/protocols/websockets/websockets_impl.pyL381-R381](https://github.com/encode/uvicorn/pull/2471/files#diff-74255e578d2ca222f3b49857a51f2a81a9228f598393e53ba4658da913931729L381-R381)
)