-
-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create setting/flag to enable/disable X-Forwarded-Port #2473
Conversation
… to populate remote address info (closes encode#1974)
This pull request is addressing the issue described in #1974 |
0c968cd
to
2164cc5
Compare
There's a failing test case in I think this PR is ready for review. Let me know if I can help with anything else or if there's anything that could be improved here :D |
Do we need to add a new flag? |
I don't mind considering X-Forwarded-Port (if available) by default if already checking for X-Forwarded-For. My decision to include a new flag was to avoid changing the default behaviour, something that some maintainers and some users usually ask for. But I can totally remove the flag and make it be considered by default +1 Just let me know. |
Let's take a step back here, and continue the discussion on #1974 (comment), please. |
I'll be closing this until we have a decision on the issue. I don't think we want this to be a parameter anyway. |
Summary
Create a new setting/flag to enable/disable X-Forwarded-Port to populate remote address info.
This flag is disabled by default. Command line options are:
--forwarded-port
--no-forwarded-port
Checklist