trust_number_of_proxies to ProxyHeadersMiddleware #2508
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The motivation for this is if you know you are behind eg loadbalancer + reverse-proxy nginx, but their IPs are not sensibly known (eg they change), you can configure the middleware to just skip the known number of them before applying any other heuristics. This should be backwards-compatible with previous versions of the middleware. This makes it easier to port code from https://werkzeug.palletsprojects.com/en/stable/middleware/proxy_fix/
Adds a new setting of
trusted_number_of_proxies
to theProxyHeadersMiddleware
that allows the user to specify the number ofproxies that are trusted to be present in the request and not otherwise
verified.
Checklist