-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/481-487 increase min upvotes per post for distribution workflow #502
Feature/481-487 increase min upvotes per post for distribution workflow #502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this!
I just noticed one small thing. Currently the "Clear Votes" and "Reset Vote Counter" appear to do the same thing (the both call upvoteService.removeByBoard(this.boardID)). Is it possible to have the "Reset Vote Counter" reset each members vote counter to the maximum amount but keep all the existing votes on the board -- or would this get too complicated?
E.g.,
- Maximum Votes per Student is set to 5
- Student Joel upvotes post "Happy Ideas" 5 times leaving now remaining votes
- Teacher clicks the "Reset Vote Counter" button
- Joel's 5 upvotes on "Happy Ideas" post remain and Joel has an additional 5 votes to spend
Thanks Joel! is there an API in the works to reset member votes for the board? see PR #487 |
I just left a comment in the issue, but I was talking with the other developers and it sounds like we would need to change too much in terms of the implementation to implement the reset the vote counter. Let's remove the "Reset Vote Counter" button from this PR. Thanks for your work! |
@JoelWiebe just pushed an update with the reset vote counter removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we just need to remove that one dialogue that I left a comment on, then please feel free to go ahead and merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this dialogue for now as we removed the button, right?
Details
Closes #481 #487