WIP: refactor(backend): Socket state management refactor + adding redis adapter #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelWiebe
reviewed
Apr 11, 2024
There was a problem hiding this comment.
Great idea using the redis adapter. Hopefully once we figure out these couple items this will provide us with some much needed stability and reliability.
Tested:
- Canvas: Create and tag posts on a canvas with two concurrent users
- Workflow: Generate 2 posts in canvas (Bug)
- Workflow: Generate 3 posts in bucket
- Workflow: Move ideas between buckets
- Workflow: Peer review ideas to move between buckets
- Workflow: Peer review ideas from canvas to bucket (Bug)
- Workflow: Generate 4 posts to canvas (Bug)
Bugs (may not be related to web sockets):
2.
- (a) When creating posts in the Workspace, posts created with tags are not displayed on the canvas.
- (b) If the final post created has a tag then the task fails to be marked as complete.
- (c) Posts are only displayed in the canvas after the canvas is refreshed--should they be showing up immediately?
- In the Workspace, when peer reviewing posts from the canvas to a bucket, all posts across the project were displayed as posts to review (including all posts from buckets and the two posts that did not appear on the canvas from the task above). Conclusion: This workflow is mistakenly providing all posts for peer review rather than only posts on the canvas.
- In the Workspace, I created all four posts with no tag. Upon completion they were all added to the canvas, but posts 1, 2, and 3 were posted twice and the 4th only once. NOTE: Could not replicate this.
- Additionally, I'm noticing only canvas events are being logged. No posts tagged or created in the Workspace are being logged. Is this unrelated to web sockets?
| this._io = io; | ||
|
|
||
| console.log('Socket server running at ' + 8000); | ||
|
|
||
| io.on('connection', (socket) => { | ||
| this._socket = socket; | ||
| // this._socket = socket; |
There was a problem hiding this comment.
Should we remove this line?
|
I just noticed another item:
|
|
Will create new issues for the existing bugs, merging this in for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Closes #{ISSUE-NUMBER}