Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 478 include the board as a workflow destination #595

Merged
merged 12 commits into from
Jul 11, 2024
Merged

Issue 478 include the board as a workflow destination #595

merged 12 commits into from
Jul 11, 2024

Conversation

marieklinaeva
Copy link
Contributor

Overview

  • Distribution workflow issues: destination to include one of the source items with multiple destinations; destination and source match the destination, error message created
  • Ordering of dest/source Options: CANVAS before BUCKETS
  • Merged with remote branch, added redis dump to gitignore
  • Prioritized projects in source and destination lists; see TODOs to complete
  • Allow for boards as destinations and changed BOARD to CANVAS
  • Added comments to create workflow component and TODOs to ts and html files
  • Added CANVAS and BUCKET identifiers to each of the destinations and sources
  • Removed if statement: add CANVAS to destination for distribution workflow

Test

  • Create distribution workflow with same destination and source (error message should occur)
  • Create distribution workflow with multiple destinations (no error message)
  • Ensure no console errors

Closes #478

marieklinaeva and others added 9 commits June 25, 2024 13:55
@marieklinaeva
Update create-workflow-modal.component.ts
2525d5e 
Removed if statement
@JoelWiebe
Added comments to create workflow component and TODOs to ts and html …
fc1ff8a 
…files
@marieklinaeva
Create dump.rdb
a75f61d
@marieklinaeva
Update create-workflow-modal.component.html
5c54872 
Added CANVAS and BUCKET identifiers to each of the destinations and sources.
@marieklinaeva
Allow for boards as destinations and changed BOARD to CANVAS
a944fe3 
Fixed issue
@JoelWiebe
Prioritized projects in source and destination lists; see TODOs to co…
93a156b 
…mplete
@JoelWiebe
merged with remote branch, added redis dump to gitignore
c088c7d
@marieklinaeva
Ordering of dest/source Options
48bb20b 
Fixed ordering
@marieklinaeva
Distribution workflows issues fixed
550d1de 
For Distribution workflows, allow the destination to include one of the source items, as long as there are multiple destinations. For distribution workflows, if there is only one destination and the source matches the destination, "Destinations may include the source, but cannot match exactly".
@marieklinaeva marieklinaeva linked an issue Jul 9, 2024 that may be closed by this pull request
Include the board as a workflow destination #478
Closed
11 tasks
@markiianbabiak markiianbabiak merged commit 938e1f5 into develop Jul 11, 2024
2 checks passed
@markiianbabiak markiianbabiak deleted the issue-478-include-the-board-as-a-workflow-destination branch July 11, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markiianbabiak markiianbabiak markiianbabiak approved these changes

@JoelWiebe JoelWiebe JoelWiebe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include the board as a workflow destination
3 participants
@marieklinaeva @JoelWiebe @markiianbabiak