599 bug update rxjs to deal with a dependacy conflict #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FUTURE: Uncomment them once the service is migrated to mongo
…ton clipping; temp fixed legacy slider display issue, temp fixed legacy radio buttons display checked issue; migrated legacy progress bars from legacy to fix display issue
…hub.com/encorelab/ck-board into 597-feature-updating-node-to-version-17
This reverts commit fe81677.
2 tasks
This was
linked to
issues
Sep 28, 2024
JoelWiebe
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Looks good to me!
Nice to see no critical frontend warnings after compiling.
Tested:
- Created new project
- Created new board (or project space)
- Created posts in canvas
- Created and assigned to a group
- Created a bucket
- Created generation task and completed task
Observations:
- No frontend or backend errors
- Console only had two unrelated warnings that I will add as separate GitHub issues (Element matching '[cdkFocusInitial]' is not focusable AND It looks like you're using ngModel on the same form field as formControl. Support for using the ngModel input property and ngModelChange event with reactive form directives has been deprecated in Angular v6 and will be removed in a future version of Angular.)
- All testing tasks were completed successfully
|
@markiianbabiak Can you confirm that @marieklinaeva will need to perform the following commands to test this branch? Check angular version and if not version 15, install angular 15
Install Node 18
Also, make sure to run "npm install" in both the frontend and backend to build with the latest dependencies. |
|
@JoelWiebe Yes, that's the correct set of commands for @marieklinaeva to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to Angular 15
Updated to Node 18
Removed references to Firebase (will need to replace with MongoDB)
Fixed visibility issues resulting from use of legacy material design elements (e.g., Slider, radio buttons, and progress bar)
Fixed projectID UI error
Migrating to node 18
Updated all the needed files for rxjs v7.
Closes #599 and #597 and #584