-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use uv to manage dependencies #1060
Conversation
@clsty For this part Lines 136 to 143 in 41520ae
As you can see. All packages in the mentioned PKGBUILD will be installed by |
Because that some issues are related to
I'm not sure whether this method will work. But we'd better avoid
We need a |
Yeah I think that I will give it a try. |
@clsty Finally I got
Also you may get some error when you run the Then to run
You can export it as an environment variable or we might move the files there to the global path where |
I do not have enough space for a fresh arch install currently so I just did a quick test on my own platform. It stuck here:
As I mentioned above,
And specifically gradience is only used to generate colorscheme for gtk:
So, how to test? Let me provide a tip (please adjust it as you like): You may edit
to (fill in the
And use |
OK I think that we are reaching to a good point here. I have modified the install script to install all needed libraries in a virtual environment. And now all I need is to test it which is what I am doing right now. Also I have fixed the As you can see in some files like this that has a shebang. Like do we really need it ? It's kinda hard and problematic to use the new python interpreter. Like it should exists in |
According to blog post and document, it's possible to point out a path like
and then as the shebang (Edit #!/usr/bin/env -S\_/bin/sh\_-xc\_"exec\_\$ILLOGICAL_IMPULSE_VIRTUAL_ENV/bin/python\_-E\_"\$0"\_"\$@""$ ./myscript.py (Other maybe related link: stackoverflow question)
Well, if you are about to remove shebang, it means that you need to modify all the codes that have involved the scripts, to use the virtual environment instead, right? For example in 215: if (self.attribute.enabled) Utils.execAsync(['bash', '-c', `pidof wayland-idle-inhibitor.py || ${App.configDir}/scripts/wayland-idle-inhibitor.py`]).catch(print)
216: else Utils.execAsync('pkill -f wayland-idle-inhibitor.py').catch(print);
221: self.attribute.enabled = !!exec('pidof wayland-idle-inhibitor.py'); See, it's not that easy, right? I'd rather just modify a single shebang in
|
OK I finished everything in my local machine and also I have installed it in a fresh arch installation (I hope that you can try it) I only have one problem, ags is not working for some reason. I have |
.config/ags/scripts/color_generation/generate_colors_material.py
Outdated
Show resolved
Hide resolved
Oh, I forgot to tell you that I've done a quick test and it seems good but just need some modifications as mentioned above. Also the new shebangs will fix the ags error (json parse error thingy). After that it's very likely I'll merge this PR, if things go as expected. |
Well, looks good. I'll merge it now. Some minor modifications will be done by me later. Thanks for your contribution. Nice job! |
OK thanks for these words. |
Also I will do the documentation tomorrow. I was about to forget about it. |
Welcome. Take your time though, no hurry. And for the fork of gradience, it seems that the final result only contains modification on And for @end-4 , since this is your project in the end, I recommend you to fork or copy the repo to your account, so that I can modify the URL in install script to the repo under your account. @end-4 A breaking change is now involved: you'll need to set environment variable I've done adding notice in
|
Thanks |
OK I still didn't create the |
closes #1017
As mentioned in #1017 many users have reported that they had a problem with the installer and basically creating a virtual environment will fix everything. We will use
uv
since it's the new way for how stuff works in python.what we will do
uv
along with the other tools. And also creating the virtual environment itself. It should be in$XDG_STATE_DIR
.requirements.in
file that contains dependencies.