Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context menu with duplicate #341

Closed
wants to merge 4 commits into from

Conversation

urbit-pilled
Copy link
Contributor

@urbit-pilled urbit-pilled commented Dec 17, 2024

/claim #201

modified #293 so that it only contains the duplication feature. (removed pin, summary, and delete functionality)

Screen.Recording.2024-12-17.at.1.44.57.PM.mov

DoomTas3r and others added 3 commits November 1, 2024 23:26
Adds a context menu with duplicate, summary, pin, and delete functions with shortcuts ctrl + d to duplicate, ctrl + p to pin. Duplicate and pin affects snapped blocks. Context menu displays when drag drop area receives a right click
@varshith257
Copy link

@urbit-pilled Thanks for your effort here but #335 has opened first and reviews are ongoing. I would like to complete this issue :)

@urbit-pilled
Copy link
Contributor Author

I saw that it wasn't even compiling so I don't think you've made enough effort to lock this issue. @varshith257.

@varshith257
Copy link

varshith257 commented Dec 17, 2024

@urbit-pilled That's a format issue and fixed it 😄

@urbit-pilled
Copy link
Contributor Author

urbit-pilled commented Dec 17, 2024

You made those fixes after mine. (Not that it was much work as most of it was done by @DoomTas3r)

@urbit-pilled
Copy link
Contributor Author

urbit-pilled commented Dec 17, 2024

I believe it was more than a format issue otherwise I wouldn't have opened a PR, it also had compiler issues too.
I don't ever open a PR that someone else is already working on unless I think that they haven't made a good effort in their PR.

That's why I opened the PR. (Because a PR that doesn't compile means that you haven't even run it on your own computer yet) @varshith257

@DoomTas3r
Copy link
Contributor

@urbit-pilled Nice, although some requested features from this proposal were left out, most notably the Ctrl-D shortcut to Duplicate.

@urbit-pilled
Copy link
Contributor Author

urbit-pilled commented Dec 17, 2024

It was a bit ambiguous to me what @manuq wanted because later on he said that the other things should be discussed first.
but I think you're right @DoomTas3r, it seems he was referring to the "pinning" and "summary" features when he was talking about features that need discussing first.

I have added back the Ctrl + d shortcut and added Delete to the dropdown menu.

@manuq
Copy link
Contributor

manuq commented Dec 18, 2024

Thanks @urbit-pilled . I squashed the commits and took the liberty to improve the commit message in #345, while still giving credit to the original author @DoomTas3r. Thanks both.

@manuq manuq closed this Dec 18, 2024
@manuq manuq mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants