Add a widget to switch between BlockCode nodes #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanmccall
force-pushed
the
add-node-switcher
branch
2 times, most recently
from
e9b679e to
5fedf6e
Compare
dylanmccall
force-pushed
the
add-node-switcher
branch
from
5fedf6e to
77127e6
Compare
dylanmccall
force-pushed
the
add-node-switcher
branch
from
5bd3961 to
50f92e8
Compare
manuq
approved these changes
Jun 19, 2024
Comment on lines
+63
to
+66
| # FIXME: We should clear the existing selection, but at the moment this | ||
| # causes the new node to be deselected due to signal handlers being | ||
| # called in the wrong order. | ||
| #_editor_selection.clear() |
There was a problem hiding this comment.
I noticed this when I tested, good to have the explanation with a FIXME note for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.endlessm.com/T35511
In the BlockCode editor, this replaces the label displaying the current node type with a dropdown menu that allows the user to switch between all the BlockCode nodes in a scene:
In addition, it adds two different empty states for the Block Code editor, when there are no BlockCode nodes in the scene, or when no BlockCode node is selected: