Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up redundant code with multiple entry blocks #72

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Clean up redundant code with multiple entry blocks #72

merged 1 commit into from
Jun 22, 2024

Conversation

dylanmccall
Copy link
Contributor

Forgot to commit this in #70 :)

@dylanmccall dylanmccall requested a review from wnbaum June 21, 2024 22:55
@dylanmccall dylanmccall marked this pull request as ready for review June 21, 2024 22:55
wnbaum
wnbaum approved these changes Jun 22, 2024
View reviewed changes
Copy link
Contributor

@wnbaum wnbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! No more unnecessary pass or signal connect statements being generated. Nice!

@wnbaum wnbaum merged commit bde4e1b into main Jun 22, 2024
2 checks passed
@wnbaum wnbaum deleted the avoid-duplicate-code branch June 22, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wnbaum wnbaum wnbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanmccall @wnbaum