Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vue.md #5398

Merged
merged 6 commits into from
Jul 4, 2024
Merged

Update vue.md #5398

merged 6 commits into from
Jul 4, 2024

Conversation

Florian-Mt
Copy link
Contributor

Specify minor versions

Specify minor versions
Copy link

welcome bot commented Jul 3, 2024

Thank you for opening this pull request 👍. If you are not familiar with the project, please check out our Contributing Guidelines and our Guiding Principles. Also take a look at our Hacking Guide if you intend to work on site internals.

@captn3m0
Copy link
Member

captn3m0 commented Jul 3, 2024

Need to understand the reasoning behind this change to see if it is helpful

  1. Setting a changelogTemplate is a good idea
  2. Will splitting into minor versions be actually helpful? the current page already suggests the correct 2 versions to use (3.4.31 or 2.7.16 with commercial support). Adding the extra releases doesn't seem to be helpful.

Same for Vue 2
@Florian-Mt
Copy link
Contributor Author

Florian-Mt commented Jul 3, 2024

I find that mentioning only major releases is vague and imprecise

@Florian-Mt
Copy link
Contributor Author

Florian-Mt commented Jul 3, 2024

Also, I often use endoflife.date not only to see if a version has reached EOL but how old it is.
Up to you to decide if you think it is relevant or not.
I don't know why the pipeline has failed, I can't check the logs.

@Florian-Mt
Copy link
Contributor Author

Ok I found:
Product Validator: Invalid releaseDate '2022-07-01' for vue.md#releases#2.7, expecting a value before eoas (2022-03-18).

@captn3m0
Copy link
Member

captn3m0 commented Jul 3, 2024

I also often use not only use endoflife.date not only to see if a version has reached EOL but how old it is.

This is helpful, thanks!

The error log says:

Product Validator: Invalid releaseDate '2022-07-01' for vue.md#releases#2.7, expecting a value before eoas (2022-03-18).

Would be nice to have eol/eoas dates for the minor releases, since the policy is known.

@Florian-Mt
Copy link
Contributor Author

Florian-Mt commented Jul 3, 2024

I can't find where does the eoas: 2022-03-18 information come from. It was added in the original commit creating vue.md.

@Florian-Mt
Copy link
Contributor Author

Florian-Mt commented Jul 3, 2024

It is the release date of Vue 3.0 (2020-09-18) + 18 months. But that does not match with what the v2 website actually says:

Vue 2.7 is the current, and final minor release of Vue 2.x. Vue 2.7 receives 18 months of LTS (long-term support) starting from its release date on July 1st, 2022.

Fix EOAS of v2.7 and add EOAS/EOL exact dates
@Florian-Mt
Copy link
Contributor Author

Florian-Mt commented Jul 3, 2024

Ok, so every time there is a new minor, the previous minor does not receive any new patch, so I can consider that each EOAS/EOL is actually the release date of the following minor.
The only exception may be 2.7, for which EOAS in uncertain (the v2 docs also say Vue 3 has been the default version of Vue since February 7, 2022.). I decided to consider EOAS to be the same as EOL (2023-12-31). Is it OK for you?

@captn3m0
Copy link
Member

captn3m0 commented Jul 4, 2024

Yes, that sounds good.

captn3m0 added 2 commits July 4, 2024 11:15
with a bonus attempt to use YAML anchors
to re-use old template.
@captn3m0
Copy link
Member

captn3m0 commented Jul 4, 2024

I've marked 2.6 as under NES commercial support as well.

@captn3m0 captn3m0 merged commit 0afc334 into endoflife-date:master Jul 4, 2024
5 checks passed
Copy link

welcome bot commented Jul 4, 2024

Thank you and congratulations for your first contribution! endoflife.date is a community wiki, and we're always looking for more contributions 🥇 💯 🎉.

@BiNZGi BiNZGi added the release-updates Pull Requests that update release information label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-updates Pull Requests that update release information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants