-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Having these empty header files prevents me from building projects vi… #872
base: master
Are you sure you want to change the base?
Conversation
See this for details: platformio/platformio-core#615 |
Doesn't seem like an Energia issue if your editor/build system can't deal with valid files |
Do these files serve any purpose? PlatformIO is more than just an editor. Doesn't seem like an Energia issue if your editor/build system can't deal — |
I have no idea but if your environment can't deal with zero length files, that is a problem with your environement |
I think the problem is that those files are there in the first place. Do
|
AFAIR, those SPI.h files are used to include the folders where they are located. Any change would require regression tests. |
I'll try to investigate then. I think it would be a worthwhile goal as it would make the Energia platform reusable elsewhere. |
Hmm, not fully understood the system but it might be something different. In this sketches the library uses the SPI library as well. So in this case the issue could come from the build system, |
If you do so, please proceed with the regression tests for most of the platforms, including build and link, upload and run. Thank you! |
So I have done an experiment where I built a binary using both master and this branch on the example in Is this a sufficient test, or am I missing something? |
Does both run successfully on each platform? The dummy |
I don't have access to all hardware platforms necessary to test this on a real device, but I would imagine they would work the same way, if they produce the same binary. I'll conduct some more thorough investigation on the rest of the libraries soon-ish. |
What exactly do you mean by |
Yes. |
Results for compiling the examples for Top is - git tag 0101E0017-emt-a61, bottom is the same with SPI.h removed.
I'll do the rest of the platforms when I find some time this weekend. |
…a PlatformIO.