Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

128 - Extract OSS SDKs from the core library #167

Merged
merged 15 commits into from
Apr 16, 2024

Conversation

VincentKobz
Copy link
Collaborator

@VincentKobz VincentKobz commented Apr 3, 2024

  • extract every OSS SDKs scanner providers from the core library (enioka_scan).
  • update the documentation to follow new changes.
  • fix the demoscannerapp to include new scanner providers in the gradle build.

#128

@VincentKobz VincentKobz requested a review from DaSpood April 3, 2024 09:32
@VincentKobz VincentKobz self-assigned this Apr 3, 2024
@VincentKobz VincentKobz force-pushed the 128-extract-oss-sdk-from-core-library branch 7 times, most recently from 3904d3c to c392b58 Compare April 3, 2024 14:43
docs/quickstart.md Outdated Show resolved Hide resolved
docs/dependencies.md Outdated Show resolved Hide resolved
docs/dependencies.md Outdated Show resolved Hide resolved
docs/dependencies.md Outdated Show resolved Hide resolved
docs/dependencies.md Outdated Show resolved Hide resolved
enioka_scan/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
enioka_scan/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
enioka_scan_athesi_rd50te/README.md Outdated Show resolved Hide resolved
@VincentKobz VincentKobz force-pushed the 128-extract-oss-sdk-from-core-library branch from 2af5ed9 to 06d26af Compare April 4, 2024 11:27
enioka_scan_zebra_dw/README.md Outdated Show resolved Hide resolved
@DaSpood
Copy link
Collaborator

DaSpood commented Apr 15, 2024

Some scanner providers seem to not be properly instanciated in the demo app:

  • GsSppScannerProvider
  • HoneywellOssSppScannerProvider

With the following error/warning in the logs:

Could not instantiate provider - usual cause is missing SDK from classpath
java.lang.ClassCastException: com.enioka.scanner.sdk.honeywelloss.spp.HoneywellOssSppScannerProvider cannot be cast to com.enioka.scanner.api.ScannerProvider
at com.enioka.scanner.LaserScanner.discoverProviders(LaserScanner.java:106)
at com.enioka.scanner.LaserScanner.discoverProviders(LaserScanner.java:73)
at com.enioka.scanner.service.ScannerService.initProviderDiscovery(ScannerService.java:176)
at com.enioka.scanner.service.ScannerService.onBind(ScannerService.java:132)
at android.app.ActivityThread.handleBindService(ActivityThread.java:5128)
at android.app.ActivityThread.-$$Nest$mhandleBindService(Unknown Source:0)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2514)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loopOnce(Looper.java:230)
at android.os.Looper.loop(Looper.java:319)
at android.app.ActivityThread.main(ActivityThread.java:8893)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:608)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)

Also the option for intent scanners is still missing from this version due to the lack of allowIntentDevices option (ScannerServiceApi.EXTRA_SEARCH_ALLOW_INTENT_BOOLEAN extra) in the default settings. IIRC you found the cause of this problem while working on the next task, it would be better to include the fix in this PR to ensure all SDKs are reachable: add a toggle for this option in the demo app's settings.

@VincentKobz VincentKobz force-pushed the 128-extract-oss-sdk-from-core-library branch from a99b9e6 to b61f722 Compare April 15, 2024 14:01
@DaSpood DaSpood merged commit 3df603e into master Apr 16, 2024
2 checks passed
@DaSpood DaSpood deleted the 128-extract-oss-sdk-from-core-library branch April 16, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants